Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix minor issues in sample code in README #451

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Conversation

bcherry
Copy link
Contributor

@bcherry bcherry commented Jul 30, 2024

I'm running through setup on the various SDKs and noticed that the sample UIKit code here had a couple minor issues that caused errors when pasted as-is

  • await in synchronous context (viewDidLoad). I replaced this with a plain Task { ... } which should be fine for sample code
  • faulty catch syntax with unnecessary trailing in - I removed the whole let bit because even fixing the syntax still leaves a compile warning about the unused variable error.
  • unnecessary ? on non-optional variables - removed
  • implicitly captured self within a closure - just added an explicit self.

@CLAassistant
Copy link

CLAassistant commented Jul 30, 2024

CLA assistant check
All committers have signed the CLA.

@hiroshihorie hiroshihorie merged commit e112832 into main Jul 31, 2024
11 checks passed
@hiroshihorie hiroshihorie deleted the bcherry/readme-updates branch July 31, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants