Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rotation in SampleBuffer Renderer #438

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Fix rotation in SampleBuffer Renderer #438

merged 1 commit into from
Jul 23, 2024

Conversation

patryk-sredzinski
Copy link
Contributor

Fixes #437

@CLAassistant
Copy link

CLAassistant commented Jul 19, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@patryk-sredzinski patryk-sredzinski mentioned this pull request Jul 19, 2024
Closed
@hiroshihorie hiroshihorie self-requested a review July 21, 2024 22:06
hiroshihorie
hiroshihorie approved these changes Jul 21, 2024
View reviewed changes
Copy link
Member

@hiroshihorie hiroshihorie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !, I was planning to fix this my self.
One concern is that I think we need to check all frames for rotation not only the first one, for example if iPhone rotates the camera the rotation will change mid-stream. But I can fix this myself.
Thanks for the PR ! 🙂

@patryk-sredzinski
Copy link
Contributor Author

@hiroshihorie Unfortunately I can see that occasionaly I still see the camera being flipped. I've got no clue why this sometimes happen.

I would not really like to check it every single frame, I'd better think of finding a solution and cases when this might change, but need to investigate it a bit more.

I'd like to continue my work on this

@hiroshihorie
Copy link
Member

hiroshihorie commented Jul 22, 2024 •
edited
Loading

Thanks, i can try to fix it when i have time.

@hiroshihorie hiroshihorie merged commit de16a17 into livekit:main Jul 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiroshihorie hiroshihorie hiroshihorie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Camera rotated when using renderMode = .sampleBuffer
3 participants
@patryk-sredzinski @CLAassistant @hiroshihorie