Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix participant.identity is nil in participantDidDisconnect delegate #408

Merged
merged 24 commits into from
Jun 21, 2024

Conversation

hiroshihorie
Copy link
Member

No description provided.

@hiroshihorie hiroshihorie changed the title Fix participant.identity is null in participantDidDisconnect delegate Fix participant.identity is nil in participantDidDisconnect delegate Jun 20, 2024
@hiroshihorie hiroshihorie changed the base branch from main to hiroshi/update-tests June 20, 2024 20:55
@hiroshihorie hiroshihorie marked this pull request as ready for review June 20, 2024 21:01
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice to see the tests!

@hiroshihorie hiroshihorie changed the base branch from hiroshi/update-tests to main June 21, 2024 09:19
@hiroshihorie hiroshihorie changed the base branch from main to hiroshi/update-tests June 21, 2024 09:19
Base automatically changed from hiroshi/update-tests to main June 21, 2024 09:19
@hiroshihorie hiroshihorie merged commit 30cb269 into main Jun 21, 2024
7 checks passed
@hiroshihorie hiroshihorie deleted the hiroshi/async-notify branch June 21, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants