Transcription events CLT-343 #406
Conversation
hiroshihorie
commented
Jun 18, 2024
•
hiroshihorie
commented
- Events for RoomDelegate
- Events for ParticipantDelegate
- State management
| guard let participant = _state.read({ | ||
| $0.remoteParticipants.values.first { $0.identity == Participant.Identity(from: packet.transcribedParticipantIdentity) } | ||
| }) else { | ||
| log("[Transcription] Could not find participant: \(packet.transcribedParticipantIdentity)", .warning) |
There was a problem hiding this comment.
@hiroshihorie you'll need to include support for transcription events coming down on the LocalParticipant as well, to record the results of STT in the agent
There was a problem hiding this comment.
I did a quick spike and it works to just change the delegate methods to receive generic Participant and TrackPublication instead of the Remote variants, change these lines up here to the following
let participant: Participant?
let identity = Participant.Identity(from: packet.transcribedParticipantIdentity)
if localParticipant.identity == identity {
participant = localParticipant
} else {
participant = _state.read({ $0.remoteParticipants.values.first { $0.identity == identity } })
}
guard let participant else {
log("[Transcription] Could not find participant: \(packet.transcribedParticipantIdentity)", .warning)
return
}
There was a problem hiding this comment.
Thank you ! will update.
|
If looks good will merge first, then think about if any state helpers are necessary. |
| override public var hash: Int { | ||
| var hasher = Hasher() | ||
| hasher.combine(id) | ||
| return hasher.finalize() |
There was a problem hiding this comment.
@hiroshihorie @lukasIO do you two think it's right to identify and hash these based on ID alone? It doesn't guarantee true equality, because a newer version could be received later that should be used instead.
There was a problem hiding this comment.
what's the intended purpose of the hash?
