Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to m114 #225

Merged
merged 6 commits into from
Jul 24, 2023
Merged

Migrate to m114 #225

merged 6 commits into from
Jul 24, 2023

Conversation

hiroshihorie
Copy link
Member

@hiroshihorie hiroshihorie commented Jul 4, 2023 •
edited
Loading

Checking if audio changes still work correctly:
@cloudwebrtc

@cloudwebrtc
Copy link
Contributor

cloudwebrtc commented Jul 5, 2023 •
edited
Loading

It works correctly, just need to change RTCAudioDevice to RTCIODevice in swift-example
livekit-examples/swift-example#17

@davidzhao
Copy link
Member

It works correctly, just need to change RTCAudioDevice to RTCIODevice in swift-example livekit-examples/swift-example#17

Is this an breaking API change?

@cloudwebrtc
Copy link
Contributor

cloudwebrtc commented Jul 7, 2023 •
edited
Loading

Yes, RTCAudioDevice has a naming conflict with RTCAudioDevice added in m114.

In our webrtc-sdk/webrtc#21 patch, RTCAudioDevice refers to a specific built-in sound card or usb sound card https://github.com/webrtc-sdk/webrtc/blob/m104_release/sdk/objc/api/peerconnection/RTCAudioDevice.h#L25,

and m114 meaning is audio device module
https://github.com/webrtc-sdk/webrtc/blob/m114_release/sdk/objc/components/audio/RTCAudioDevice.h#L167

@davidzhao
Copy link
Member

Got it. we should bump at least the minor version then for Swift.

@hiroshihorie hiroshihorie marked this pull request as ready for review July 13, 2023 09:37
@cloudwebrtc
Copy link
Contributor

https://github.com/webrtc-sdk/Specs/releases/tag/114.5735.02

@hiroshihorie
Copy link
Member Author

@cloudwebrtc nice !

@hiroshihorie hiroshihorie merged commit 63a83e2 into main Jul 24, 2023
@hiroshihorie hiroshihorie deleted the migrate-to-m114 branch July 24, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidzhao davidzhao davidzhao approved these changes

@cloudwebrtc cloudwebrtc Awaiting requested review from cloudwebrtc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hiroshihorie @cloudwebrtc @davidzhao