-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AVSampleBufferDisplayLayer
rendering mode to VideoView
#222
Conversation
AVSampleBufferDisplayLayer
rendering mode to VideoView
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg. just one question re: classname
import Foundation | ||
import WebRTC | ||
|
||
internal class InternalSampleBufferVideoRenderer: NativeView { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does Internal
reference? or should we call it AVSampleBufferDisplayLayerRenderer
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not exposed, the VideoView
uses it internally as a subview.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it, sounds good!
This is needed for PiP.