openai: fix low timeouts #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1ea0125 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
davidzhao
approved these changes
Oct 16, 2024
| @@ -75,11 +75,11 @@ def __init__( | |||
| api_key=api_key, | |||
| base_url=base_url, | |||
| http_client=httpx.AsyncClient( | |||
| timeout=httpx.Timeout(timeout=30, connect=10, read=5, pool=5), | |||
| timeout=httpx.Timeout(connect=15.0, read=5.0, write=5.0, pool=5.0), | |||
There was a problem hiding this comment.
the change is from 10s -> 15s for connect? what does removing timeout mean? should we also increase the other timeouts?
There was a problem hiding this comment.
timeout is to default everything to 30.0
There was a problem hiding this comment.
llm was OK, it's more for TTS/STT that the change is going from 5 to 15
This was referenced Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix ridiculously low timeouts
future work would be to expose those in every client we have
fix #807