Allow on demand dev releases

[lukasIO]

No description provided.

[nbsp]

pnpm ci:version --snapshot dev already produces x.y.z-dev-TIMESTAMP, there's no need to add another -dev to it, just trim down the last dash.

[lukasIO]

ah, thanks! will do

[lukasIO]

pushed the change, it looks a bit ugly as I read that nested expressions aren't supported. If you were thinking of a more elegant solution feel free to commit it to this branch!

[nbsp]

i think this one is clearer: 's|-\([0-9]*\)$|\1|' (take dash-numbers-eol and turn it into numbers-eol). doesn't even need an if clause, really.
also note that sed regexes require \( \) for grouping, with literal backslashes, and don't support \d as a capture group. https://sed.js.org has worked for me for quick testing

[lukasIO]

yeah, that seems cleaner!
the -E argument allows for brackets not to be escaped, but can go with the regular version of escaping it.

[theomonnom]

Can pypi recognize v0.1.0-dev too? I've only used v0.1.0.dev0

[theomonnom]

https://peps.python.org/pep-0440/

Epoch segment: N!
Release segment: N(.N)*
Pre-release segment: {a|b|rc}N
Post-release segment: .postN
Development release segment: .devN

[theomonnom]

Ah ignore my comments. it seems like it should work: https://peps.python.org/pep-0440/#development-release-separators

Development releases allow a ., -, or a _ separator as well as omitting the separator all together. The normal form of this is with the . separator. This allows versions such as 1.2-dev2 or 1.2dev2 which normalize to 1.2.dev2.

From @nbsp comment, not sure if the timestamp will be recognized (x.y.z-dev-TIMESTAMP)

[nbsp]

the timestamp is only numbers, so even though it doesn't follow the "spirit" of the spec, i think it technically abides by it. version numbers aren't consecutive but they are ordered

0.0.0-dev-1234567890 -> 0.0.0-dev1234567890 -> 0.0.0.dev1234567890

[theomonnom]

Just did some testing with the official regex:

>>> import re
>>> VERSION_PATTERN = r"""
...     v?
...     (?:
...         (?:(?P<epoch>[0-9]+)!)?                           # epoch
...         (?P<release>[0-9]+(?:\.[0-9]+)*)                  # release segment
...         (?P<pre>                                          # pre-release
...             [-_\.]?
...             (?P<pre_l>(a|b|c|rc|alpha|beta|pre|preview))
...             [-_\.]?
...             (?P<pre_n>[0-9]+)?
...         )?
...         (?P<post>                                         # post release
...             (?:-(?P<post_n1>[0-9]+))
...             |
...             (?:
...                 [-_\.]?
...                 (?P<post_l>post|rev|r)
...                 [-_\.]?
...                 (?P<post_n2>[0-9]+)?
...             )
...         )?
...         (?P<dev>                                          # dev release
...             [-_\.]?
...             (?P<dev_l>dev)
...             [-_\.]?
...             (?P<dev_n>[0-9]+)?
...         )?
...     )
...     (?:\+(?P<local>[a-z0-9]+(?:[-_\.][a-z0-9]+)*))?       # local version
... """
>>> 
>>> _regex = re.compile(
...     r"^\s*" + VERSION_PATTERN + r"\s*$",
...     re.VERBOSE | re.IGNORECASE,
... )
>>> 
>>> 
>>> _regex.match("v0.1.0.dev0")
<re.Match object; span=(0, 11), match='v0.1.0.dev0'>
>>> _regex.match("v0.1.0.dev-0")
<re.Match object; span=(0, 12), match='v0.1.0.dev-0'>
>>> _regex.match("v0.1.0.dev-1")
<re.Match object; span=(0, 12), match='v0.1.0.dev-1'>
>>> _regex.match("v0.1.0.dev-143535365346")
<re.Match object; span=(0, 23), match='v0.1.0.dev-143535365346'>
>>> _regex.match("v0.1.0-dev-143535365346")
<re.Match object; span=(0, 23), match='v0.1.0-dev-143535365346'>
>>> _regex.match("v0.1.0-dev-153562")
<re.Match object; span=(0, 17), match='v0.1.0-dev-153562'>

Seems like the current format is OK, lgtm! Thanks!

[theomonnom]

Note that this one is not valid tho:
_regex.match("v0.1.0-dev1-1234532")

[lukasIO]

should I merge this into main or into dev ? 👀
In the end we'll need it in both anyways as the action won't show up in the actions tab if it's not present in the default branch of the repo, just wondering about the ordering mostly.

[theomonnom]

merging to main lgtm