fix: empty agent transcript #1148
Conversation
🦋 Changeset detectedLatest commit: 146820f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -883,24 +883,25 @@ async def _execute_function_calls() -> None: | |||
| if interrupted: | |||
| collected_text += "..." | |||
|
|
|||
| msg = ChatMessage.create(text=collected_text, role="assistant") | |||
| self._chat_ctx.messages.append(msg) | |||
| if collected_text: | |||
There was a problem hiding this comment.
this would skip speech_handle.mark_speech_committed(), do we want to mark it as committed before skipping the other operations?
There was a problem hiding this comment.
model's response contains empty content when it responds with a tool call, should we still mark it as committed? because after executing function model will respond with string that will be marked as committed
| @@ -883,24 +883,25 @@ async def _execute_function_calls() -> None: | |||
| if interrupted: | |||
| collected_text += "..." | |||
|
|
|||
| msg = ChatMessage.create(text=collected_text, role="assistant") | |||
| self._chat_ctx.messages.append(msg) | |||
| if collected_text: | |||
There was a problem hiding this comment.
When can this happen? I'm more worried about the cause than fixing the scenario where it is indeed empty
There was a problem hiding this comment.
This happens when agent finish speaking tool call's response. we get an extra empty transcript. screenshot
Can there be a possiblity when llm response is just empty?
There was a problem hiding this comment.
It's the same speech id which has tool calls with empty content from model's response, do we need to mark it at committed?
There was a problem hiding this comment.
Ah right, I think we should add new arguments to the agent_speech_committed event. I think it is a valid usecase to have an empty content but having function calls
There was a problem hiding this comment.
something like below?
def mark_speech_committed(self, is_content_empty: bool) -> None:
self._speech_committed = True
self._is_content_empty = is_content_empty
There was a problem hiding this comment.
Ah right, I think we should add new arguments to the agent_speech_committed event.
@theomonnom wouldn't that break existing callbacks? I'm not sure if there's value in it because function calls are supposed to be handled by the framework
There was a problem hiding this comment.
I will think more about that alongside the new IO proposal
There was a problem hiding this comment.
Let's put this PR in standby for now, we should be able to add new arguments without breaking
This PR fixes the bug where a message was being added to the chat context even when
msg.contentwas empty.It's the same speech id which has tool calls with no content from model's response