This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
[22780] Ensure the compositorType property can be set to "none" #7378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch ensures the compositorType property can be set to "none". Previously this enumeration value was set to read-only, thus an error was thrown when attempting to set the compositorType to "none"
runrevmark
reviewed
Jun 30, 2021
There was a problem hiding this comment.
So we need to check whether this was a 'bug' introduced in the refactor - the docs state none is returned if no compositor... And this change allows setting to none certainly, but it will still return empty in that case.
It might be just a docs bug if none has never figured as a compositor type!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch ensures the compositorType property can be set to "none".
Previously this enumeration value was set to read-only, thus an error
was thrown when attempting to set the compositorType to "none"
Closes https://quality.livecode.com/show_bug.cgi?id=22780