Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Picker): fix for data controlled mode #995

Merged
merged 101 commits into from
Feb 1, 2024
Merged

fix(Picker): fix for data controlled mode #995

merged 101 commits into from
Feb 1, 2024

Conversation

VadymBezpalko
Copy link
Contributor

@VadymBezpalko VadymBezpalko commented Feb 1, 2024 •
edited
Loading

Resolves: #992

Description

Adding data-controlled mode: when there is selected prop passed to the Picker component it will track only those indexes as selected and would ignore internal state.

Storybook

https://feature-992--613a8e945a5665003a05113b.chromatic.com

Checklist

Obligatory:

  • Self review (use this as your final check for proposed changes before requesting the review)
  • Add reviewers (livechat/design-system)
  • Add correct label
  • Assign pull request with the correct issue

VadymBezpalko and others added 30 commits November 2, 2023 14:03
@VadymBezpalko
feat(Popover): refactor component using floating-ui
2769557
@VadymBezpalko
feat(Popover): story styles
a723989
@VadymBezpalko
feat(Popover): story styling fix
f6afd53
@VadymBezpalko
feat(Popover): improving types
a47530f
@VadymBezpalko
feat(Popover): additional props
1e0ef4b
@VadymBezpalko
feat(Popover): tests
d427696
@VadymBezpalko
feat(Popover): review fixes
03341b9
@VadymBezpalko
Merge branch 'main' into feature/874
e5ffc86
@VadymBezpalko
feat(Picker):
9ce6ff4
@VadymBezpalko
feat(Picker): separate PickerListComponent
dd0b8ed
@VadymBezpalko
feat(Picker): separated PickerListItem component
2f0ac4a
@VadymBezpalko
feat(Picker): separated PickerTrigger component
25fa227
@VadymBezpalko
Merge branch 'main' into feature/777
9d73a63
@VadymBezpalko
feat(Picker): multiple select WIP
14a24c7
@VadymBezpalko
feat(Picker): handle select improvements
361af1b
@VadymBezpalko
feat(Picker): improved list styles
ebc4849
@VadymBezpalko
feat(Picker): PickerTrigger component
a7a7f64
@VadymBezpalko
feat(Picker): PickerTriggerBody component
e7e2d5e
@VadymBezpalko
feat(Picker): handling select in different way
4c9a925
@VadymBezpalko
feat(Picker): keyboard nav fixes
cbe69b4
@VadymBezpalko
feat(Picker): removing typeahead
468ddaf
@VadymBezpalko
feat(Picker): group header WIP
a336ef1
@VadymBezpalko
feat(Picker): set list to have the same width as trigger
ea05616
@VadymBezpalko
feat(Picker): group header styles fix
9e79e11
@VadymBezpalko
feat(Picker): onselect and onremove improvement
d455f3d
@VadymBezpalko
feat(Picker): onremove improvement
b8f7f37
@VadymBezpalko
feat(Picker): autocomplete
56f89f3
@VadymBezpalko
feat(Picker): using item keys instead of indexes
ed67728
@VadymBezpalko
feat(Picker): applying className and id props
9d2a765
@VadymBezpalko
feat(Picker): adding disabled item styles
52f38cb
VadymBezpalko and others added 16 commits December 21, 2023 13:35
@VadymBezpalko
fix(Picker): exposing virtuoso props
3b1f956
@VadymBezpalko
Merge branch 'main' into feature/777
6d8d51d 
# Conflicts:
#	package-lock.json
#	packages/react-components/package.json
@VadymBezpalko
fix(Picker): package lock update
31f5e2a
@VadymBezpalko
fix(Picker): extracting props to the useFloatingPicker
613df81
@VadymBezpalko
fix(Picker): extracting methods to the usePickerItems
d80a967
@VadymBezpalko
fix(Picker): useFloatingPicker improvements
8b5c535
@VadymBezpalko
Merge branch 'main' into feature/777-picker-refactor
3e52ed6 
# Conflicts:
#	packages/react-components/src/components/Picker/Picker.tsx
@VadymBezpalko
Merge branch 'main' into feature/777-picker-refactor
faeea60
@VadymBezpalko
Merge branch 'main' into feature/777-picker-refactor
2f5b812
@VadymBezpalko
fix(Picker): fix for openedOnInit variant
ab884f2
@VadymBezpalko
Merge branch 'main' into feature/777-picker-refactor
03828ea
@VadymBezpalko
fix(Picker): adding controlled mode to the component
8f3929c
@VadymBezpalko
fix(Picker): controlled mode improvements
f94114a
@VadymBezpalko
fix(Picker): minor refactor
3318ac7
@VadymBezpalko
fix(Picker): adding placement property
441b00a
@VadymBezpalko
fix(Picker): fix for data controlled mode
0cc50ef
@VadymBezpalko VadymBezpalko added the bug Something isn't working label Feb 1, 2024
@VadymBezpalko VadymBezpalko added this to the v1.0 milestone Feb 1, 2024
@VadymBezpalko VadymBezpalko self-assigned this Feb 1, 2024
@VadymBezpalko VadymBezpalko marked this pull request as ready for review February 1, 2024 13:27
vladko-uxds
vladko-uxds approved these changes Feb 1, 2024
View reviewed changes
Copy link

@vladko-uxds vladko-uxds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Base automatically changed from feature/993 to main February 1, 2024 14:23
@VadymBezpalko
Merge branch 'main' into feature/992
f6d698c 
# Conflicts:
#	packages/react-components/src/components/Picker/Picker.tsx
#	packages/react-components/src/components/Picker/hooks/usePickerItems.ts
@VadymBezpalko VadymBezpalko merged commit 1e6740b into main Feb 1, 2024
5 checks passed
@VadymBezpalko VadymBezpalko deleted the feature/992 branch February 1, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladko-uxds vladko-uxds vladko-uxds approved these changes

@ashbork ashbork ashbork approved these changes

@marcinsawicki marcinsawicki Awaiting requested review from marcinsawicki

Assignees

@VadymBezpalko VadymBezpalko

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.

[BUG] Allow control over Picker's state
3 participants
@VadymBezpalko @ashbork @vladko-uxds