Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Button): Fix for Button component height #926

Closed
wants to merge 14 commits into from
Closed

Conversation

VadymBezpalko
Copy link
Contributor

Resolves: #920 #896

Description

Properly handling button height for elements with border and without it

Storybook

https://feature-920--613a8e945a5665003a05113b.chromatic.com

Checklist

Obligatory:

  • Self review (use this as your final check for proposed changes before requesting the review)
  • Add reviewers (livechat/design-system)
  • Add correct label
  • Assign pull request with the correct issue

@VadymBezpalko VadymBezpalko added bug Something isn't working design UI/UX oriented issue labels Dec 15, 2023
@VadymBezpalko VadymBezpalko self-assigned this Dec 15, 2023
@VadymBezpalko VadymBezpalko linked an issue Dec 15, 2023 that may be closed by this pull request
@VadymBezpalko VadymBezpalko changed the title Feature/920 fix(Button): Fix for Button component height Dec 15, 2023
@VadymBezpalko
Copy link
Contributor Author

Unfortunately, implementing these changes will lead to a breaking change, as altering the height parameter to min-height could disrupt the visual appearance in scenarios where a custom height is used, both within and outside DS components. Setting a min-height value could override any custom height that is set to be less than the proposed min-height.
To avoid causing visual issues in existing implementations, it is better to introduce this improvement in the next major version of the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working design UI/UX oriented issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Button] - Update button height [Button] - styles issue
2 participants