Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(PromoBannerV2): vertical mode, class name props for content containers #925

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

marcinsawicki
Copy link
Contributor

@marcinsawicki marcinsawicki commented Dec 14, 2023

Resolves: #893

Description

Flag to enable vertical mode without container queries.
New props to pass own styles to content containers.

Storybook

https://feature-893--613a8e945a5665003a05113b.chromatic.com/?path=/story/components-promobannerv2--default

Checklist

Obligatory:

  • Self review (use this as your final check for proposed changes before requesting the review)
  • Add reviewers (livechat/design-system)
  • Add correct label
  • Assign pull request with the correct issue

@marcinsawicki marcinsawicki added the feature New feature or request label Dec 14, 2023
@marcinsawicki marcinsawicki added this to the v1.0 milestone Dec 14, 2023
@marcinsawicki marcinsawicki self-assigned this Dec 14, 2023
Copy link

@vladko-uxds vladko-uxds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@marcinsawicki marcinsawicki merged commit 4dd64c0 into main Dec 14, 2023
2 checks passed
@marcinsawicki marcinsawicki deleted the feature/893 branch December 14, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PromoBannerV2] - vertical mode + possibility to pass own class directly for content elements
3 participants