Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ActionMenu): Possibility to check the selected options #918

Merged
merged 1 commit into from
Dec 11, 2023
Merged

feat(ActionMenu): Possibility to check the selected options #918

merged 1 commit into from
Dec 11, 2023

Conversation

marcinsawicki
Copy link
Contributor

@marcinsawicki marcinsawicki commented Dec 11, 2023 •
edited
Loading

Description

Restored possibility to indicate the selected option on the list.

Storybook

https://feature-action-menu-active-state--613a8e945a5665003a05113b.chromatic.com/?path=/story/components-actionmenu--with-selected-options

Checklist

Obligatory:

  • Self review (use this as your final check for proposed changes before requesting the review)
  • Add reviewers (livechat/design-system)
  • Add correct label
  • Assign pull request with the correct issue

@marcinsawicki marcinsawicki added the feature New feature or request label Dec 11, 2023
@marcinsawicki marcinsawicki added this to the v1.0 milestone Dec 11, 2023
@marcinsawicki marcinsawicki self-assigned this Dec 11, 2023
vladko-uxds
vladko-uxds approved these changes Dec 11, 2023
View reviewed changes
Copy link

@vladko-uxds vladko-uxds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@marcinsawicki marcinsawicki merged commit 7a24d8f into main Dec 11, 2023
2 checks passed
@marcinsawicki marcinsawicki deleted the feature/action-menu-active-state branch December 11, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladko-uxds vladko-uxds vladko-uxds approved these changes

@VadymBezpalko VadymBezpalko VadymBezpalko approved these changes

Assignees

@marcinsawicki marcinsawicki

Labels
feature New feature or request
Projects
LiveChat Design System
Archived in project
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@marcinsawicki @VadymBezpalko @vladko-uxds