feat(AppFrame): mobile view and MobileNavigation component #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VadymBezpalko
approved these changes
Sep 9, 2024
| @@ -44,6 +44,7 @@ export const NavigationItem: React.FC<INavigationItemProps> = ({ | |||
| isActive, | |||
| onClick, | |||
| className, | |||
| isMobile, | |||
There was a problem hiding this comment.
Do we need to add this prop? Can't we imply this from its wrapper MobileNavigation?
There was a problem hiding this comment.
Moved that flag to the AppFrameContext
| @@ -87,6 +89,7 @@ export const NavigationItem: React.FC<INavigationItemProps> = ({ | |||
| {...props} | |||
| > | |||
| {icon} | |||
| {isMobile && label} | |||
There was a problem hiding this comment.
Instead of using separate prop isMobile, I'd use only the label and show it when this component placed inside of MobileNavigation.
| id="item-1" | ||
| label="Item 1" | ||
| icon={<div>Icon</div>} | ||
| url="#" |
There was a problem hiding this comment.
The url prop is optional, you do not need to pass it.
| @@ -30,30 +32,39 @@ const Frame = (props: IAppFrameProps) => { | |||
| isVisible: isSideNavigationVisible, | |||
| elementRef: sideNavWrapperRef, | |||
| }); | |||
| const { isMobile, handleResize } = useMobileViewDetector({ | |||
There was a problem hiding this comment.
To avoid confusing the name handleResize with a function, I'd suggest to add it for example: handleResizeRef
| @@ -31,6 +35,10 @@ export interface IAppFrameProps extends ComponentCoreProps { | |||
| * The CSS class for the content container | |||
| */ | |||
| contentClassName?: string; | |||
| /** | |||
There was a problem hiding this comment.
Please add information about default value
vladko-uxds
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1289
Description
Mobile view for
AppFrame.Added required prop
mobileNavigationandMobileNavigationcomponent (act asNavigationbut for mobile view).UI changes related to the mobile view (top bars overlap the view).
Storybook
https://feature-1289--613a8e945a5665003a05113b.chromatic.com
Checklist
Obligatory: