Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ActionMenu): change opacity to color token for disabled item #1313

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

marcinsawicki
Copy link
Contributor

@marcinsawicki marcinsawicki commented Sep 4, 2024

Resolves: #1309

Description

Added color token for a disabled button to show disabled state. Removed the opacity prop, which will solve the problem of displaying tooltips for disabled elements.

Storybook

https://feature-1309--613a8e945a5665003a05113b.chromatic.com

Checklist

Obligatory:

  • Self review (use this as your final check for proposed changes before requesting the review)
  • Add correct label
  • Assign pull request with the correct issue

@marcinsawicki marcinsawicki added the bug Something isn't working label Sep 4, 2024
@marcinsawicki marcinsawicki added this to the Cycle #9 milestone Sep 4, 2024
@marcinsawicki marcinsawicki self-assigned this Sep 4, 2024
@marcinsawicki marcinsawicki marked this pull request as ready for review September 4, 2024 13:13
@marcinsawicki marcinsawicki linked an issue Sep 4, 2024 that may be closed by this pull request
1 task
Copy link

@vladko-uxds vladko-uxds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@marcinsawicki marcinsawicki merged commit 340a4c6 into main Sep 5, 2024
11 checks passed
@marcinsawicki marcinsawicki deleted the feature/1309 branch September 5, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] ActionMenu: Tooltip inherits opacity from disabled button
3 participants