Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Picker): fixed the issue with virtual focus when filtering the list #1267

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

marcinsawicki
Copy link
Contributor

@marcinsawicki marcinsawicki commented Jul 31, 2024

Resolves: #1262

Description

Fixed the issue with incorrectly adding elements using keyboard controls when the first element is selected, and then the list is filtered.

Storybook

https://feature-1262--613a8e945a5665003a05113b.chromatic.com

Checklist

Obligatory:

  • Self review (use this as your final check for proposed changes before requesting the review)
  • Add correct label
  • Assign pull request with the correct issue

@marcinsawicki marcinsawicki added the bug Something isn't working label Jul 31, 2024
@marcinsawicki marcinsawicki added this to the Cycle #9 milestone Jul 31, 2024
@marcinsawicki marcinsawicki self-assigned this Jul 31, 2024
@marcinsawicki marcinsawicki linked an issue Jul 31, 2024 that may be closed by this pull request
1 task
Copy link
Contributor

@VadymBezpalko VadymBezpalko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@marcinsawicki marcinsawicki merged commit 0e4fd96 into main Jul 31, 2024
5 checks passed
@marcinsawicki marcinsawicki deleted the feature/1262 branch July 31, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] Picker and keyboard issue
2 participants