feat(Badge): deprecate some props and new UpdateBadge and StatusBadge components #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VadymBezpalko
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
Good job 👍
I left some minor comments and also have a suggestion to group the default badge files in the storybook as well - in the similar style as StatusBadge and UpdateBadge. So the Badge title probably should be smth like this: title: 'Components/Badge/Badge',
| &--3XS { | ||
| @include size(4px); | ||
|
|
||
| border-width: 1px; |
There was a problem hiding this comment.
I'd suggest including border-width into the size mixin and make it as a second parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1232
Description
Changes in
Badgecomponent:kind-secondaryis deprecated (added information)size-largeis deprecated (added information)type-dotis deprecated (added information)Added new
UpdateBadgeandStatusBadgecomponents with stories related to theBadgecomponent.Storybook
https://feature-1232--613a8e945a5665003a05113b.chromatic.com
Checklist
Obligatory: