feat(ActionBar): logic refactor #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VadymBezpalko
approved these changes
Jul 3, 2024
| threshold: 1, | ||
| }; | ||
| const shouldDisplayMenu = !isScrollType && menuItemsKeys.length !== 0; | ||
| const singleElementSize = 44; |
There was a problem hiding this comment.
Shouldn't it be available as a prop? If not I'd suggest to move it outside the component's function.
There was a problem hiding this comment.
Currently not, but in the future I plan to improve that component and give a possibility to set the buttons size.
| const observer = new ResizeObserver((entries) => { | ||
| const { width, height } = entries[0].contentRect; | ||
| const containerSize = vertical ? height : width; | ||
| const exstraSpacing = menuOptions.length > 0 ? 60 : 0; |
|
|
||
| return filteredOptions.map((o) => { | ||
| const getMenuItems = (menuOptions: IActionBarOption[]) => |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1214
Description
Logic refactor:
IntersectionObservertoResizeObserver- from now logic will observe the container size changes, then will calculate how many option buttons will fit in the currently available space:IntersectionObserver) and will be available in the menuabsolutepositioning)Storybook
https://feature-action-bar-menu-icon-fix--613a8e945a5665003a05113b.chromatic.com
Checklist
Obligatory:
livechat/design-system)