Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DatePicker): prevent infinite update #1128

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

marcinsawicki
Copy link
Contributor

@marcinsawicki marcinsawicki commented Jun 3, 2024

Resolves: #{issue-number}

Description

This fix should prevent to infinite loop update of the component, on month prop change when toMonth is set.

Storybook

https://feature-date-picker-update-loop-fix--613a8e945a5665003a05113b.chromatic.com

Checklist

Obligatory:

  • Self review (use this as your final check for proposed changes before requesting the review)
  • Add reviewers (livechat/design-system)
  • Add correct label
  • Assign pull request with the correct issue

@marcinsawicki marcinsawicki added the bug Something isn't working label Jun 3, 2024
@marcinsawicki marcinsawicki self-assigned this Jun 3, 2024
@marcinsawicki marcinsawicki marked this pull request as ready for review June 3, 2024 09:11
@marcinsawicki marcinsawicki added this to the v1.0 milestone Jun 3, 2024
@marcinsawicki marcinsawicki merged commit 38ddd8f into main Jun 3, 2024
5 checks passed
@marcinsawicki marcinsawicki deleted the feature/date-picker-update-loop-fix branch June 3, 2024 13:39
Copy link

@vladko-uxds vladko-uxds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants