Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Picker): filtering by secondaryText #1126

Merged
merged 1 commit into from
May 28, 2024
Merged

fix(Picker): filtering by secondaryText #1126

merged 1 commit into from
May 28, 2024

Conversation

marcinsawicki
Copy link
Contributor

@marcinsawicki marcinsawicki commented May 28, 2024 •
edited
Loading

Resolves: #1103

Description

Added the possibility to filter items by secondaryText.
Added info about how filtering works to docs.

Storybook

https://feature-1103--613a8e945a5665003a05113b.chromatic.com

Checklist

Obligatory:

  • Self review (use this as your final check for proposed changes before requesting the review)
  • Add reviewers (livechat/design-system)
  • Add correct label
  • Assign pull request with the correct issue

@marcinsawicki marcinsawicki added bug Something isn't working feature New feature or request labels May 28, 2024
@marcinsawicki marcinsawicki added this to the v1.0 milestone May 28, 2024
@marcinsawicki marcinsawicki marked this pull request as ready for review May 28, 2024 10:05
vladko-uxds
vladko-uxds approved these changes May 28, 2024
View reviewed changes
Copy link

@vladko-uxds vladko-uxds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@marcinsawicki marcinsawicki merged commit 7ba98f9 into main May 28, 2024
11 checks passed
@marcinsawicki marcinsawicki deleted the feature/1103 branch May 28, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladko-uxds vladko-uxds vladko-uxds approved these changes

@VadymBezpalko VadymBezpalko VadymBezpalko approved these changes

Assignees
No one assigned
Labels
bug Something isn't working feature New feature or request
Projects
LiveChat Design System
Archived in project
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.

[Picker] - Add possibility to filter by secondaryText
3 participants
@marcinsawicki @VadymBezpalko @vladko-uxds