Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Color): use root with light theme as default theme #1018

Merged
merged 1 commit into from
Mar 4, 2024
Merged

fix(Color): use root with light theme as default theme #1018

merged 1 commit into from
Mar 4, 2024

Conversation

marcinsawicki
Copy link
Contributor

@marcinsawicki marcinsawicki commented Feb 27, 2024 •
edited
Loading

Resolves: #{issue-number}

Description

Use root in the light theme, as this is the default palette.

Storybook

https://feature-css-light-theme-root--613a8e945a5665003a05113b.chromatic.com/?path=/docs/foundations-color--docs

Checklist

Obligatory:

  • Self review (use this as your final check for proposed changes before requesting the review)
  • Add reviewers (livechat/design-system)
  • Add correct label
  • Assign pull request with the correct issue

@marcinsawicki marcinsawicki added the design UI/UX oriented issue label Feb 27, 2024
@marcinsawicki marcinsawicki added this to the v1.0 milestone Feb 27, 2024
vladko-uxds
vladko-uxds approved these changes Feb 27, 2024
View reviewed changes
Copy link

@vladko-uxds vladko-uxds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@marcinsawicki marcinsawicki self-assigned this Feb 28, 2024
@marcinsawicki marcinsawicki merged commit 937a140 into main Mar 4, 2024
11 checks passed
@marcinsawicki marcinsawicki deleted the feature/css-light-theme-root branch March 4, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladko-uxds vladko-uxds vladko-uxds approved these changes

@VadymBezpalko VadymBezpalko VadymBezpalko approved these changes

Assignees

@marcinsawicki marcinsawicki

Labels
design UI/UX oriented issue
Projects
LiveChat Design System
Archived in project
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@marcinsawicki @VadymBezpalko @vladko-uxds