Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Picker placeholder prop isn't applied consistently #990

Closed
1 task done
ashbork opened this issue Jan 30, 2024 · 0 comments · Fixed by #991
Closed
1 task done

[BUG] Picker placeholder prop isn't applied consistently #990

ashbork opened this issue Jan 30, 2024 · 0 comments · Fixed by #991
Labels
bug Something isn't working

Comments

@ashbork
Copy link
Contributor

ashbork commented Jan 30, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

The placeholder is only applied to the trigger - the actual search field doesn't have the proper placeholder.

Steps To Reproduce

  1. Set a placeholder prop on the Picker component
  2. Open the Picker
  3. Note that the search placeholder is Select option

Expected Behavior

The placeholder should be applied to the search field.

Screenshots

Monosnap screencast 2024-01-30 13-56-05

Design system package(s) version

@livechat/design-system-react-components@1.2.0

Environment

No response

Additional context

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
LiveChat Design System
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#990 - add placeholder to Picker's search input livechat/design-system
1 participant
@ashbork