Skip to content

Commit

Permalink
[Misc] Remove user-facing error for removed VLM args (vllm-project#9104)
Browse files Browse the repository at this point in the history
  • Loading branch information
DarkLight1337 authored and liuyanyi committed Oct 6, 2024
1 parent 7f616e5 commit 291619f
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 13 deletions.
4 changes: 0 additions & 4 deletions docs/source/models/vlm.rst
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,6 @@ The :class:`~vllm.LLM` class can be instantiated in much the same way as languag
llm = LLM(model="llava-hf/llava-1.5-7b-hf")
.. note::
We have removed all vision language related CLI args in the ``0.5.1`` release. **This is a breaking change**, so please update your code to follow
the above snippet. Specifically, ``image_feature_size`` can no longer be specified as we now calculate that internally for each model.

To pass an image to the model, note the following in :class:`vllm.inputs.PromptType`:

* ``prompt``: The prompt should follow the format that is documented on HuggingFace.
Expand Down
10 changes: 1 addition & 9 deletions vllm/entrypoints/llm.py
Original file line number Diff line number Diff line change
Expand Up @@ -180,15 +180,7 @@ def __init__(

if "disable_log_stats" not in kwargs:
kwargs["disable_log_stats"] = True
removed_vision_keys = (
"image_token_id",
"image_feature_size",
"image_input_shape",
"image_input_type",
)
if any(k in kwargs for k in removed_vision_keys):
raise TypeError(
"There is no need to pass vision-related arguments anymore.")

engine_args = EngineArgs(
model=model,
tokenizer=tokenizer,
Expand Down

0 comments on commit 291619f

Please sign in to comment.