forked from nodejs/node
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
src: fix memory leak for v8.serialize
When Buffer::New passes in existing data, it cannot be garbage collected in js synchronous execution. Fixes: nodejs#40828 Refs: nodejs#38300
- Loading branch information
1 parent
4508c8c
commit 809386a
Showing
2 changed files
with
24 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
'use strict'; | ||
// Flags: --expose-gc | ||
|
||
require('../common'); | ||
const v8 = require('v8'); | ||
const assert = require('assert'); | ||
|
||
const before = process.memoryUsage.rss(); | ||
|
||
for (let i = 0; i < 1000000; i++) { | ||
v8.serialize(''); | ||
} | ||
|
||
global.gc(); | ||
|
||
const after = process.memoryUsage.rss(); | ||
|
||
if (process.config.variables.asan) { | ||
assert(before * 10 > after, `asan: before=${before} after=${after}`); | ||
} else { | ||
assert(after - before < 1024 * 1024 * 10, `before=${before} after=${after}`); | ||
} |