add coc_git_blame support #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR: 1. add coc_git_blame support (requires coc-git plugin) 2. fix typo, an extra space which makes things look strange
liuchengxu
reviewed
Dec 18, 2020
| let l:coc_status = coc#status() | ||
| if !empty(get(b:, 'coc_git_blame', '')) | ||
| if len(l:coc_status) + len(b:coc_git_blame) < winwidth("%") / 3 | ||
| return l:coc_status.' '.b:coc_git_blame |
There was a problem hiding this comment.
I think the full blame info can be very long and consume too many valuable spaces of the statusline. If you only show them when the info's short, that's kind of strange as they can just show occasionally.
There was a problem hiding this comment.
yes @liuchengxu currently it only shows when the info isn't too long. I'm actually not sure on the correct way to see git blame.
in virtual text it can be too distracting while coding
in status line it looks better but maybe not enough space
There was a problem hiding this comment.
You can truncate the blame info to a short one, but not sure that's still very useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: