Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add admin setting to restrict rooms #67

Merged
merged 5 commits into from
Aug 29, 2020
Merged

Conversation

sualko
Copy link
Member

@sualko sualko commented Aug 27, 2020

This pull requests allows administrators to limit the amount of settings each user can configure. The following restrictions are possible on a group/global level:

  • maximum number of rooms. If the global limit is set to 0 no one can create a room, but rooms can still be shared with everyone. For this reason the room manager is also visible to everyone. If multiple rules apply for a user, the maximum is chosen.
  • access types. All matching rules are combined.
  • max participants limit. The maximum of all valid restrictions is applied. For example if the global default is 0, you can define an unlimited rule for another group. This is also true for the max. room property.
  • recordings. Once the user is in a group which allows recordings, he can enable the recording feature.

@digitalrevisor @jacotec @remmedia @garblixa would be great if you could test this, before I merge it into master.

2020-08-28 11 58 08 localhost 281490b69039

fix #43
fix #53

@garblixa
Copy link

Hello Klaus,

many thanks for this enhancement!
Unfortunately I do not have a development environment to build and test the package. But I'm happy to report possible errors if you have integrated the changes.

Kind regards
Klaus

@sualko
Copy link
Member Author

sualko commented Aug 28, 2020

@garblixa no problem. Thanks for your reply.

I changed the behavior of the room restriction, it works now similar to all other options. Means access options are combined from all matching rules. I changed the description above accordingly.

@digitalrevisor
Copy link

Hello @sualko . This is very cool. I've installed it on our development enviroment to make some tests. It seems to be working fine so far. Only problem I've had is trying to turn off recordings for a group. I get a 500 server error when I do that. Maybe problem when with my installation but I don't know. I attached an image showing the error.

error1

I think these features will be very useful for many. I atleast know it is helpful for our use cases.

@sualko
Copy link
Member Author

sualko commented Aug 29, 2020

@digitalrevisor thanks for testing. Can you provide the response from this request and maybe the corresponding nc log entry? Because I'm unable to reproduce your behaviour.

@sualko
Copy link
Member Author

sualko commented Aug 29, 2020

I did some more tests and it seams to be stable. Therefore I merge it now. If you find any bugs with this feature, please open a new issue.

@sualko sualko merged commit 2c5ff0d into master Aug 29, 2020
@sualko sualko deleted the feat-restrictions branch August 29, 2020 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No meeting access for users not in restricted groups Admin settings to limit user options
3 participants