Update to std 0.99.0 #27
Conversation
|
Is there a way to do this as a squash commit? That is if you think this is a valuable PR. It would also be nice to lock a release to a range of supported deno versions. Not that I want to downgrade. But as Deno version increases, it does seem to break a lot of packages. Deno giving a warning with what versions it has been tested against would be nice. |
@tamusjroyce Sure, I can create a squash commit when we land this |
|
I'll try to get to this tonight or later this week. Thanks for kicking of the ci stack! |
…iginal code. Next: need deno lint --ignore=swc_wasm/wasm.js as pre-commit or pre-push hook
|
Is there a way to get |
There was a problem hiding this comment.
Ready for review with lint issues fixed (should have known deno lint --ignore=swc_wasm/wasm.js was needed. can see lint issues now)
Please edit and update README.md -> import { parse, print } from "https://x.nest.land/swc@0.0.6/mod.ts"; with a new version if published to x.nest.land
|
@wongjiahau or @littledivy, would you have a chance to run the workflow for this? mostly curious if I got everything. You might have a better attempt at upgrading to 0.99. I think demo_swc is immensely useful before jumping directly into rust + swc. Hoping others feel the same. Also curious about ajv to rust. Since ajv is a json schema compiler, it would make sense as rust. And give deno extra feature/security people desire (built-in validation). |
|
@tamusjroyce you need to run |
…repush cross-platform way of running these
There was a problem hiding this comment.
Please review and re-run pipelines.
run-prepush.bat and run-prepush.sh should be able to run prereq's I was missing. would be nice as a prepush hook (though the npm version has broken pushing without --no-verify flag on windows). But I didn't want to overkill it with anything as advanced as denode or velociraptor. run-prepush tested in git-bash, cmd, and powershell only. not tested under wsl1 ubuntu (posix, not Linux), macos (also posix, not Linux), ubuntu Linux, centos, or gentoo
|
Thank you @wongjiahau or @littledivy for all the assistance and patience. Hoping I have it this time (finally) |
|
Sorry just saw the message! I'll run the pipeline for you |
|
I will add |
There was a problem hiding this comment.
@wongjiahau pinging again for another PR. Was able to reproduce the errors in the pipeline local. After updating lexical-core using cargo, the rust build succeeded. swc-wasm/wasm.js was updated as well.
The three deno examples worked local. But I am still green when it comes to rust.
|
Will leave bumping swc to a future PR PS C:\Users\Owner\Projects\deno_swc\swc_wasm> cargo update error[E0603]: module error[E0603]: module (if you notice PS>, I am glad to support powershell via vscode. But I do strongly dislike any tcl-based language! I will never support how arrays work in PS >.<) |
|
@tamusjroyce LGTM /cc @littledivy |
Found this to be broken. This is a great alternative to esprima + typescript nodejs modules!
I wonder why there isn't more effort to use swc to convert node packages into deno? Though I am not interested in upgrading a node modules dependencies. The whole point of Deno is to avoid dependency overflow. But if dependency migration is done manually, I would hope this would lead to less of them.