Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(OpenAPI): Correctly handle type keyword #3715

Merged
merged 4 commits into from
Sep 3, 2024
Merged

fix(OpenAPI): Correctly handle type keyword #3715

merged 4 commits into from
Sep 3, 2024

Conversation

provinzkraut
Copy link
Member

Correctly handle OpenAPI schema generation for type aliases generated with the type keyword.

Fixes #3714.

@provinzkraut provinzkraut requested review from a team as code owners September 3, 2024 08:36
@github-actions github-actions bot added area/private-api This PR involves changes to the privatized API size: small type/bug labels Sep 3, 2024
@github-actions github-actions bot added the area/ci This PR involves changes to the CI/Infra label Sep 3, 2024
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.29%. Comparing base (d8b7d6e) to head (893a8f7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3715   +/-   ##
=======================================
  Coverage   98.29%   98.29%           
=======================================
  Files         330      330           
  Lines       15118    15125    +7     
  Branches     2401     2403    +2     
=======================================
+ Hits        14860    14867    +7     
  Misses        116      116           
  Partials      142      142           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Sep 3, 2024

@cofin cofin merged commit c6173a3 into main Sep 3, 2024
26 checks passed
@cofin cofin deleted the fix/3714 branch September 3, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci This PR involves changes to the CI/Infra area/private-api This PR involves changes to the privatized API pr/internal size: small type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: "type" keyword doesn't behave the same as TypeAlias
2 participants