Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add async websocket_connect to AsyncTestClient #3328

Conversation

kedod
Copy link
Contributor

@kedod kedod commented Apr 6, 2024

Description

  • Add async websocket_connect to AsyncTestClient

Closes #3133

@kedod kedod requested review from a team as code owners April 6, 2024 16:38
@kedod kedod force-pushed the 3133-support-websocket-connect-in-async-test-client branch 2 times, most recently from 17aa143 to 7f40ec5 Compare April 6, 2024 16:39
Copy link

codecov bot commented Apr 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.26%. Comparing base (fac641a) to head (395662e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3328   +/-   ##
=======================================
  Coverage   98.26%   98.26%           
=======================================
  Files         322      322           
  Lines       14720    14733   +13     
  Branches     2342     2343    +1     
=======================================
+ Hits        14464    14477   +13     
  Misses        117      117           
  Partials      139      139           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kedod kedod force-pushed the 3133-support-websocket-connect-in-async-test-client branch from 7f40ec5 to 9472266 Compare April 6, 2024 16:43
@kedod kedod changed the title Add async websocket_connect to AsyncTestClient feat: Add async websocket_connect to AsyncTestClient Apr 6, 2024
@kedod kedod force-pushed the 3133-support-websocket-connect-in-async-test-client branch from 9472266 to 395662e Compare April 6, 2024 16:52
Copy link

github-actions bot commented Apr 6, 2024

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3328

Copy link
Member

@cofin cofin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cofin cofin merged commit 43e3041 into litestar-org:main Apr 6, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Support Websockets on the async tests client
2 participants