Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/remove session from hooks #82

Closed
wants to merge 3 commits into from

Conversation

achampagnedev
Copy link
Contributor

@achampagnedev achampagnedev commented Nov 8, 2022

Project organization

Description

The goal of this PR is to remove the use of useSession as well as removing the Session Context.

How to test

N/A for now

Checklist

  • Update related changelogs
  • Update docs if necessary

@vercel
Copy link

vercel bot commented Nov 8, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Nov 8, 2022 at 4:39AM (UTC)
storybook-components ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Nov 8, 2022 at 4:39AM (UTC)
storybook-templates ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Nov 8, 2022 at 4:39AM (UTC)

@vercel vercel bot temporarily deployed to Preview – docs November 8, 2022 04:33 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-components November 8, 2022 04:36 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-templates November 8, 2022 04:39 Inactive
@achampagnedev
Copy link
Contributor Author

@antho1404 @cpvdeveloper There are two commits:

  1. The simple swaps of useSession to useWeb3React when possible

  2. Trying to remove the ready and useEagerConnect by introducing a property userHasBeenReconnected that we would pass to templates on the client side. Really not sure of that direction.

Here's the related PR on marketplace-template: liteflow-labs/starter-kit#32

Take note this was not working this is just the latest version of where I was at.

@achampagnedev
Copy link
Contributor Author

@antho1404
Copy link
Member

closing in favor of #90

@antho1404 antho1404 closed this Dec 7, 2022
@antho1404 antho1404 deleted the feature/remove-session-from-hooks branch December 7, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants