lightningd: use fsync not fdatasync.

Apparently MacOS doesn't always have fdatasync, so use fsync. Even more importantly check whether it succeeds! Fixes: ElementsProject#6516 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
litch · Aug 11, 2023 · 6faefda · 6faefda
1 parent 385c05b
commit 6faefda
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/lightningd/configs.c b/lightningd/configs.c
@@ -504,7 +504,8 @@ static bool configfile_replace_var(struct lightningd *ld,
 	contents = tal_strjoin(tmpctx, take(lines), "\n", STR_TRAIL);
 	if (!write_all(outfd, contents, strlen(contents)))
 		fatal("Writing %s: %s", template, strerror(errno));
-	fdatasync(outfd);
+	if (fsync(outfd) != 0)
+		fatal("Syncing %s: %s", template, strerror(errno));
 
 	if (rename(template, cv->file) != 0)
 		fatal("Renaming %s over %s: %s",