Skip to content

Commit

Permalink
bpo-37331: Clarify format of socket handler messages in the documenta…
Browse files Browse the repository at this point in the history
…tion. (pythonGH-14234)
  • Loading branch information
vsajip authored and lisroach committed Sep 9, 2019
1 parent 732c3a3 commit e9cb36f
Showing 1 changed file with 14 additions and 4 deletions.
18 changes: 14 additions & 4 deletions Doc/library/logging.handlers.rst
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,12 @@ sends logging output to a network socket. The base class uses a TCP socket.
.. method:: makePickle(record)

Pickles the record's attribute dictionary in binary format with a length
prefix, and returns it ready for transmission across the socket.
prefix, and returns it ready for transmission across the socket. The
details of this operation are equivalent to::

data = pickle.dumps(record_attr_dict, 1)
datalen = struct.pack('>L', len(data))
return datalen + data

Note that pickles aren't completely secure. If you are concerned about
security, you may want to override this method to implement a more secure
Expand All @@ -499,8 +504,12 @@ sends logging output to a network socket. The base class uses a TCP socket.

.. method:: send(packet)

Send a pickled string *packet* to the socket. This function allows for
partial sends which can happen when the network is busy.
Send a pickled byte-string *packet* to the socket. The format of the sent
byte-string is as described in the documentation for
:meth:`~SocketHandler.makePickle`.

This function allows for partial sends, which can happen when the network
is busy.


.. method:: createSocket()
Expand Down Expand Up @@ -561,7 +570,8 @@ over UDP sockets.

.. method:: send(s)

Send a pickled string to a socket.
Send a pickled byte-string to a socket. The format of the sent byte-string
is as described in the documentation for :meth:`SocketHandler.makePickle`.


.. _syslog-handler:
Expand Down

0 comments on commit e9cb36f

Please sign in to comment.