Improve error messages when operation conversion fails #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Wrap errors during operation processing in an ex-info. The message contains the operation name and the ex-data contains the source operation. - Throw ex-infos with a "missing schema" message instead of NPEs when a necessary schema is null. This turns errors that previously looked like: `java.lang.NullPointerException: Cannot invoke "io.swagger.v3.oas.models.media.Schema.getTypes()" because "schema" is null` into this: `clojure.lang.ExceptionInfo: Exception processing operation "TestOp": Missing schema`
|
Looks good, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading to 0.0.6, I got NPEs with my existing OpenAPI definitions. Evidently there is a response in my code somewhere missing its schema, but it's difficult to track down where. To aid in debugging, I added the operationId to error messages. I also added a more clear error message when a schema is missing instead of letting it produce an NPE.
This turns errors that previously looked like:
java.lang.NullPointerException: Cannot invoke "io.swagger.v3.oas.models.media.Schema.getTypes()" because "schema" is nullinto this:
clojure.lang.ExceptionInfo: Exception processing operation "TestOp": Missing schema