Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: errow with the `uses' attribute must be a path, a Docker image, or owner/repo@ref #1753

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

lisphilar
Copy link
Owner

@lisphilar lisphilar commented Oct 3, 2024

Related issues

Follow-up for #1752

What was changed

Fix the error with the `uses' attribute must be a path, a Docker image, or owner/repo@ref.

Summary by Sourcery

Fix the error related to the 'uses' attribute in GitHub Actions workflows by specifying the version reference for each action, ensuring compatibility and stability in CI processes.

CI:

  • Specify the version reference for GitHub Actions in the CI workflows by appending '@main' or '@master' to the 'uses' attribute in various workflow files.

@lisphilar lisphilar added the development Add tests or refactoring label Oct 3, 2024
@lisphilar lisphilar added this to the Release 3.1.3 milestone Oct 3, 2024
Copy link
Contributor

sourcery-ai bot commented Oct 3, 2024

Reviewer's Guide by Sourcery

This pull request fixes an error related to the uses attribute in GitHub Actions workflows. The main change is updating the references to action versions from unspecified to either @main or @master.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Update GitHub Actions to use specific versions
  • Change unspecified action versions to '@main' for most actions
  • Update 'hattan/verify-linked-issue-action' to use '@master'
  • Update 'linhbn123/rebase-pull-requests' to use '@master'
.github/workflows/test.yml
.github/workflows/deploy.yml
.github/workflows/pr_verify_linked_issue.yml
.github/workflows/rebase-pull-requests.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lisphilar - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider using specific version tags (e.g., @v1.2.3) instead of @main for critical actions to ensure better stability and reproducibility of your workflows.
  • Great job on systematically updating all action references. This improves the overall maintainability of the workflow files.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟡 Security: 4 issues found
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

.github/workflows/test.yml Show resolved Hide resolved
.github/workflows/deploy.yml Show resolved Hide resolved
.github/workflows/pr_verify_linked_issue.yml Show resolved Hide resolved
.github/workflows/rebase-pull-requests.yml Show resolved Hide resolved
@lisphilar lisphilar merged commit dfc3d66 into main Oct 3, 2024
30 of 33 checks passed
@delete-merged-branch delete-merged-branch bot deleted the issue1752_fu branch October 3, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Add tests or refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant