Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch up with the change of compressed file format of population data #1721

Merged
merged 11 commits into from
Aug 18, 2024

Conversation

lisphilar
Copy link
Owner

@lisphilar lisphilar commented Jul 26, 2024

Related issues

fix #1720

What was changed

Catch up with the change of compressed file format from .zip to .csv.gz regarding population data.

Summary by Sourcery

This pull request addresses issue #1720 by updating the URL for downloading World Population Prospects data to reflect the change in file format from .zip to .csv.gz. Additionally, a minor correction was made to the citation comment.

  • Bug Fixes:
    • Updated the URL for downloading World Population Prospects data to reflect the change in file format from .zip to .csv.gz.

@lisphilar lisphilar added the bug Something isn't working label Jul 26, 2024
@lisphilar lisphilar added this to the Release 3.1.2 milestone Jul 26, 2024
Copy link
Contributor

sourcery-ai bot commented Jul 26, 2024

Reviewer's Guide by Sourcery

This pull request addresses issue #1720 by updating the dataset download URL in the _WPP class to reflect the change in file format from .zip to .csv.gz. Additionally, a minor correction was made to a comment, changing 'Citation' to 'Citations'.

File-Level Changes

Files Changes
covsirphy/downloading/_db_wpp.py Updated the dataset download URL to reflect the change in file format from .zip to .csv.gz and corrected a comment typo.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@lisphilar lisphilar changed the title fix #1720 Catch up with the change of compressed file format from .zip to .csv.gz Jul 26, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lisphilar - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@lisphilar lisphilar changed the title Catch up with the change of compressed file format from .zip to .csv.gz Catch up with the change of compressed file format of population data Jul 26, 2024
@lisphilar lisphilar merged commit cdda4f0 into main Aug 18, 2024
13 checks passed
@delete-merged-branch delete-merged-branch bot deleted the issue1720 branch August 18, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] BadZipFile error with population data
1 participant