-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch up with the change of compressed file format of population data #1721
Conversation
Reviewer's Guide by SourceryThis pull request addresses issue #1720 by updating the dataset download URL in the _WPP class to reflect the change in file format from .zip to .csv.gz. Additionally, a minor correction was made to a comment, changing 'Citation' to 'Citations'. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lisphilar - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Related issues
fix #1720
What was changed
Catch up with the change of compressed file format from .zip to .csv.gz regarding population data.
Summary by Sourcery
This pull request addresses issue #1720 by updating the URL for downloading World Population Prospects data to reflect the change in file format from .zip to .csv.gz. Additionally, a minor correction was made to the citation comment.