Clang and warnings fixes #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clang-check warned about depecrated use of implicitly defined copy constructor since copy assignment existed. Rule of Five.
open-std.org/jtc1/sc22/wg21/docs/papers/2019/p1161r3.html
iglesias
commented
Apr 15, 2024
| ASSERT_EQ(static_cast<int>(pg[target_dimension]), td); | ||
| ASSERT_EQ(static_cast<int>(pg[num_neighbors]), k); | ||
| } | ||
|
|
||
| TEST(Interface, OneParameterParametersSet) | ||
| { | ||
| int td = 3; | ||
| tapkee::ParametersSet pg = tapkee::kwargs[target_dimension = td]; | ||
| tapkee::ParametersSet pg = tapkee::kwargs[(target_dimension = td)]; |
There was a problem hiding this comment.
Oeps, I think I overlooked when changing this one ':-) without parentheses there should still be no warning in this one. I will modify it back.
iglesias
commented
Apr 15, 2024
| @@ -220,7 +220,7 @@ TEST(Interface, NoReductionMethodSetFailPassThru) | |||
|
|
|||
| TapkeeOutput output; | |||
| // should fail with missed parameter | |||
| ASSERT_THROW(output = embed(data.begin(), data.end(), kcb, dcb, fcb, tapkee::kwargs[eigen_method = Dense]), | |||
| ASSERT_THROW(output = embed(data.begin(), data.end(), kcb, dcb, fcb, tapkee::kwargs[(eigen_method = Dense)]), | |||
There was a problem hiding this comment.
Same as in the other comment in this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've started onboarding llvm tooling (off-topic, just for info, I am aiming at doing some toy exercise with AST matching), and started running experimenting with
clang-check chain_interface.hpp.The ones in the unit test were compilation warnings related to multi-dimensional indexing.
I didn't run it in other files yet. I'd say let's keep the PR open for some days to continue pushing small fixes like these one.