Remove copy ctor and use nullptr

lisitsyn · Apr 11, 2024 · f1a361a · f1a361a
1 parent 22c8f4d
commit f1a361a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/include/tapkee/projection.hpp b/include/tapkee/projection.hpp
@@ -24,15 +24,12 @@ struct ProjectionImplementation
 //! A pimpl wrapper for projecting function
 struct ProjectingFunction
 {
-    ProjectingFunction() : implementation(NULL)
+    ProjectingFunction() : implementation()
     {
     }
     ProjectingFunction(ProjectionImplementation* impl) : implementation(impl)
     {
     }
-    ProjectingFunction(const ProjectingFunction& other) : implementation(other.implementation)
-    {
-    }
     //! Projects provided vector to new space
     //! @param vec vector to be projected
     //! @return projected vector

diff --git a/test/unit/interface.cpp b/test/unit/interface.cpp
@@ -130,7 +130,7 @@ TEST(Interface, NoDataPassThru)
     // that's normal
     ASSERT_EQ(0, output.embedding.rows());
     // that's normal
-    ASSERT_EQ(NULL, output.projection.implementation.get());
+    ASSERT_EQ(nullptr, output.projection.implementation.get());
 }
 
 TEST(Interface, ParameterTargetDimension)