-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark results as OK, how? #175
Comments
I'm taking a look, Baruch |
Hah,
and coming from Isaacs, no less 🙃 So, potential ideas here:
Out of these, (1) sounds like a nice way to ease the burden for end users but it also means it couples the lockfile to the package manifest which I don't like. Can you share a simple lockfile that makes use of those package aliases so I can check if the alias is mentioned somewhere else in the lockfile? Also, which version is it? |
* Add support for Angular 16. * Rewritten CI testing for multiple NodeJS, ESLint and Angular version. * Fix linting for lockfile. See lirantal/lockfile-lint#175 & isaacs/jackspeak#5 * Update all packages and run linting & Prettier. * [Fix SonarCloud warning about duplicates in regex.](https://sonarcloud.io/project/issues?open=AYJ_Asgte7FPvNTvNf5F&id=jerone_eslint-plugin-angular-template-consistent-this) * Connect SonarLint VSCode extension.
So I'm running the lockfile-linter and I get for example these results:
I research this and I find it because of this package: https://github.com/isaacs/cliui/blob/aa397fedbd0550c9925af6b62f970de663285641/package.json#L52-L57
I don't like it but it seems to be OK.
What should I do to continue enabling the
validate-package-names
rule and not failed on those packages?The text was updated successfully, but these errors were encountered: