fix: Get the nightly build working #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Quote the args going into the make target. This is so that if they are empty (ie values are being left to defaults) they show up as `""` and the calling binary wont complain about flags needing to be set. 1. Ensure that if a step in the Makefile fails the target exits 1. Doing with with `|| exit 1` for now, which hopefully will be enough. 1. Pin the version of Containerd to 1.6.6. The recent 1.6.7 release requires `gcc-11`. Getting that version sent me down a bit of a rabbit hole. `11` is not "natively" available on Ubuntu 20.04 (you can get it by adding the apt testing repo, but it is just a bit irritating to then swap out gcc 9 for 11 after the fact). So I tried bumping to Ubuntu 22.04, which lead to some annoyances, first with this new GUI whenever you `apt update` etc which has to be deactivated via an env var, and then after that my microvms lost DNS resolution and NAT connectivity. I could have only bumped the devices running flintlock to 22.04 and left the device serving as the management cluster as 20.04, but I decided it was better if we had a dedicated ticket to get everything working on 22.04, so I am going to come back to this another day. For now I just want to get the nightlies working.
|
going rogue and approving myself because i did not yet put branch protection on this mwahahaha |
Callisto13
added a commit
to liquidmetal-dev/flintlock
that referenced
this pull request
Aug 8, 2022
Just temporarily. The 1.6.7 release requires a newer gcc version which means we would have to bump our ubuntu version (to get the newer gcc easily) which comes with a few challenges. It may not be much of a big deal at flintlock's level, but I wanted to get the nightlies working while I figure it out. See liquidmetal-dev/liquid-metal-acceptance-tests#11
Callisto13
added a commit
to liquidmetal-dev/flintlock
that referenced
this pull request
Aug 8, 2022
Just temporarily. The 1.6.7 release requires a newer gcc version which means we would have to bump our ubuntu version (to get the newer gcc easily) which comes with a few challenges. It may not be much of a big deal at flintlock's level, but I wanted to get the nightlies working while I figure it out. See liquidmetal-dev/liquid-metal-acceptance-tests#11
Callisto13
added a commit
to liquidmetal-dev/flintlock
that referenced
this pull request
Aug 8, 2022
Just temporarily. The 1.6.7 release requires a newer gcc version which means we would have to bump our ubuntu version (to get the newer gcc easily) which comes with a few challenges. It may not be much of a big deal at flintlock's level, but I wanted to get the nightlies working while I figure it out. See liquidmetal-dev/liquid-metal-acceptance-tests#11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
are empty (ie values are being left to defaults) they show up as
""and the calling binary wont complain about flags needing to be set.
with with
|| exit 1for now, which hopefully will be enough.requires
gcc-11. Getting that version sent me down a bit of arabbit hole.
11is not "natively" available on Ubuntu 20.04 (youcan get it by adding the apt testing repo, but it is just a bit
irritating to then swap out gcc 9 for 11 after the fact).
So I tried bumping to Ubuntu 22.04, which lead to some annoyances,
first with this new GUI whenever you
apt updateetc which has to bedeactivated via an env var, and then after that my microvms lost DNS
resolution and NAT connectivity. I could have only bumped the devices
running flintlock to 22.04 and left the device serving as the
management cluster as 20.04, but I decided it was better if we had a
dedicated ticket to get everything working on 22.04, so I am going to
come back to this another day. For now I just want to get the
nightlies working.