Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Edit service file to wait on containerd #567

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

Callisto13
Copy link
Member

Flintlock depends on containerd so it should wait for it to become available and stop when the containerd service stops.
In a dev environment, the containerd service may be running under another name, so flintlock should watch the correct one.

@Callisto13 Callisto13 added the kind/bug Something isn't working label Oct 19, 2022
@Callisto13 Callisto13 requested a review from yitsushi October 19, 2022 11:40
@codecov-commenter
Copy link

Codecov Report

Base: 56.68% // Head: 56.57% // Decreases project coverage by -0.10% ⚠️

Coverage data is based on head (e50de8e) compared to base (76a0a37).
Patch has no changes to coverable lines.

❗ Current head e50de8e differs from pull request most recent head faa056a. Consider uploading reports for the commit faa056a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #567      +/-   ##
==========================================
- Coverage   56.68%   56.57%   -0.11%     
==========================================
  Files          57       57              
  Lines        2768     2768              
==========================================
- Hits         1569     1566       -3     
- Misses       1059     1061       +2     
- Partials      140      141       +1     
Impacted Files Coverage Δ
pkg/queue/queue.go 93.93% <0.00%> (-6.07%) ⬇️
pkg/process/process.go 39.62% <0.00%> (-1.89%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Callisto13 Callisto13 merged commit 0d29198 into liquidmetal-dev:main Oct 20, 2022
@Callisto13 Callisto13 deleted the fix-flint-service branch October 20, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants