Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curl scripts to make Vagrantfile self-contained #535

Merged

Conversation

nikimanoledaki
Copy link
Contributor

@nikimanoledaki nikimanoledaki commented Sep 19, 2022

What this PR does / why we need it:

Previously, using the Vagrantfile required cloning the Flintlock repo because it was reading scripts/devpool.sh and scripts/example-config.toml from a local path. Now, it curls these scripts so that the Vagrantfile can be used independently from the repo. :)

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@nikimanoledaki nikimanoledaki changed the title Curl devpool.sh to make Vagrantfile self-contained Curl devpool.sh to make Vagrantfile self-contained Sep 19, 2022
@nikimanoledaki nikimanoledaki changed the title Curl devpool.sh to make Vagrantfile self-contained Curl scripts to make Vagrantfile self-contained Sep 19, 2022
@Callisto13
Copy link
Member

Do people use Vagrantfiles without cloning the repo? (Asking because I for real did not know that was a thing and assumed ppl always clone like I do 😆 )

@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2022

Codecov Report

Base: 56.57% // Head: 56.57% // No change to project coverage 👍

Coverage data is based on head (ab22ff8) compared to base (70e020d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #535   +/-   ##
=======================================
  Coverage   56.57%   56.57%           
=======================================
  Files          57       57           
  Lines        2768     2768           
=======================================
  Hits         1566     1566           
  Misses       1061     1061           
  Partials      141      141           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nikimanoledaki
Copy link
Contributor Author

I do! 😄 I copied it here and made some changes (needed Ubuntu 2204, more CPU/RAM, and a bunch of deps).

Increases project coverage by +0.03%

You are most welcome!

@Callisto13 Callisto13 added the kind/feature New feature or request label Sep 21, 2022
@Callisto13
Copy link
Member

Increases project coverage by +0.03%

You are most welcome!

lol codecov what are you even for smh

@Callisto13
Copy link
Member

Ideally the vagrantfile (and everyone else) should be using https://github.com/weaveworks-liquidmetal/flintlock/blob/main/hack/scripts/provision.sh instead... I will make a note of that to do later.

Callisto13
Callisto13 previously approved these changes Sep 21, 2022
@Callisto13
Copy link
Member

gah can you sign your commit? assuming this is Niki and not some imposter... 🧐

Callisto13
Callisto13 previously approved these changes Sep 21, 2022
Curl devpool.sh to make Vagrantfile self-contained

Curl scripts/example-config.toml instead of local path
@nikimanoledaki
Copy link
Contributor Author

Done! :))

@Callisto13 Callisto13 merged commit 1063089 into liquidmetal-dev:main Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants