-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Curl scripts to make Vagrantfile self-contained #535
Curl scripts to make Vagrantfile self-contained #535
Conversation
devpool.sh
to make Vagrantfile self-contained
2c48611
to
f531f78
Compare
devpool.sh
to make Vagrantfile self-contained
Do people use Vagrantfiles without cloning the repo? (Asking because I for real did not know that was a thing and assumed ppl always clone like I do 😆 ) |
Codecov ReportBase: 56.57% // Head: 56.57% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #535 +/- ##
=======================================
Coverage 56.57% 56.57%
=======================================
Files 57 57
Lines 2768 2768
=======================================
Hits 1566 1566
Misses 1061 1061
Partials 141 141 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I do! 😄 I copied it here and made some changes (needed Ubuntu 2204, more CPU/RAM, and a bunch of deps).
You are most welcome! |
lol codecov what are you even for smh |
Ideally the vagrantfile (and everyone else) should be using https://github.com/weaveworks-liquidmetal/flintlock/blob/main/hack/scripts/provision.sh instead... I will make a note of that to do later. |
gah can you sign your commit? assuming this is Niki and not some imposter... 🧐 |
f531f78
to
5027414
Compare
Curl devpool.sh to make Vagrantfile self-contained Curl scripts/example-config.toml instead of local path
5027414
to
ab22ff8
Compare
Done! :)) |
What this PR does / why we need it:
Previously, using the Vagrantfile required cloning the Flintlock repo because it was reading
scripts/devpool.sh
andscripts/example-config.toml
from a local path. Now, it curls these scripts so that the Vagrantfile can be used independently from the repo. :)Special notes for your reviewer:
Checklist: