feat: cloudhypervisor api client #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardcase
added
kind/feature
Callisto13
reviewed
Aug 23, 2022
pkg/cloudhypervisor/client.go
Outdated
| VmmShutdown(ctx context.Context) error | ||
| // Info returns general information about the cloud-hypervisor Virtual Machine (VM) instance. | ||
| Info(ctx context.Context) (*VmInfo, error) | ||
| //Counters(ctx context.Context) *VmmCo |
There was a problem hiding this comment.
Ah, thats a future todo that i forgot to remove. I have removed it now :)
pkg/cloudhypervisor/client.go
Outdated
Comment on lines
38
to
66
| // PowerButton triggers a power button in the VM. | ||
| PowerButton(ctx context.Context) error |
There was a problem hiding this comment.
What does this mean? Like on/off?
There was a problem hiding this comment.
Well depends on what the power button is configured to do.
There was a problem hiding this comment.
I updated the comment.
pkg/cloudhypervisor/client.go
Outdated
| func (c *client) VmmPing(ctx context.Context) (*VmmPingResponse, error) { | ||
| resp := &VmmPingResponse{} | ||
|
|
||
| if err := c.builder.Clone().Path("vmm.ping").ToJSON(resp).Fetch(ctx); err != nil { |
There was a problem hiding this comment.
would be good to have all these "vmm.x" strings as consts
There was a problem hiding this comment.
I agree. I have moved these all to consts.
This change adds a Cloud Hypervisor API client. This will be used in a later implementation to enable Flintlock to talk to running instances of Cloud Hypervisor. This functionality will not be used initially. Signed-off-by: Richard Case <richard.case@outlook.com>
Callisto13
reviewed
Sep 27, 2022
| Clone(). | ||
| Path(PathVmBoot). | ||
| AddValidator(CustomErrValidator(map[int]string{ | ||
| 404: "The VM instance could not boot because it is not created yet", |
There was a problem hiding this comment.
would be good to have all these as consts, but happy to leave that as a TODO for later
Callisto13
reviewed
Sep 27, 2022
Comment on lines
+50
to
+53
| if err = json.Unmarshal(data, dest); err != nil { | ||
| return err | ||
| } | ||
| return nil |
There was a problem hiding this comment.
could be
Suggested change
| if err = json.Unmarshal(data, dest); err != nil { | |
| return err | |
| } | |
| return nil | |
| return json.Unmarshal(data, dest) |
but not bothered
Callisto13
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This change adds a Cloud Hypervisor API client. This will be used in a
later implementation to enable Flintlock to talk to running instances of
Cloud Hypervisor.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Relates #417
Special notes for your reviewer:
This functionality will not be used initially.
Checklist: