feat: force dhcp to use mac as client identifier #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Callisto13
reviewed
Aug 23, 2022
infrastructure/firecracker/config.go
Outdated
| Match: cinetwork.Match{}, | ||
| DHCP4: firecracker.Bool(true), | ||
| DHCP6: firecracker.Bool(true), | ||
| DHCPIdentifier: firecracker.String("mac"), |
There was a problem hiding this comment.
would be good to have that as a const, but otherwise LGTM
Callisto13
previously approved these changes
Aug 23, 2022
This change will force DHCP to use the mac address as the client identifier when requesting a mac address. Without this (depending on your distro) it may not use a mac address and the mv may not get a ip address assigned to it. Signed-off-by: Richard Case <richard.case@outlook.com>
Callisto13
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This change will force DHCP to use the mac address as the client
identifier when requesting a mac address. Without this (depending on
your distro) it may not use a mac address and the mv may not get a ip
address assigned to it.
Signed-off-by: Richard Case richard.case@outlook.com
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #518
Special notes for your reviewer:
Checklist: