fix: explicitly close grpc client connection #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Callisto13
previously approved these changes
Aug 18, 2022
richardcase
force-pushed
the
fix_grpc_connection_close
branch
3 times, most recently
from
ec342e2 to
dcd7332
Compare
When calling flintlock we where not explicitly closing the client connection to the grpc server. As a result a goroutine is kept alive for each client request and the number continue to rise until the server can't accept any more requests. This change will explicitly call `Close` for the underlying grpc client connection which helps to ensure server side resource usage is kept to a minimum. Signed-off-by: Richard Case <richard.case@outlook.com>
richardcase
force-pushed
the
fix_grpc_connection_close
branch
from
dcd7332 to
c9ad8c8
Compare
Callisto13
approved these changes
Aug 18, 2022
yitsushi
changed the title
yitsushi
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When calling flintlock we where not explicitly closing the client
connection to the grpc server. As a result a goroutine is kept alive for
each client request and the number continue to rise until the server
can't accept any more requests.
This change will explicitly call
Closefor the underlying grpc clientconnection which helps to ensure server side resource usage is kept to a
minimum.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Relates liquidmetal-dev/flintlock#503
Special notes for your reviewer:
Checklist: