Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Redeem Manager test to increase coverage PE-1432 #305

Merged

Conversation

juliaaschmidt
Copy link
Contributor

@juliaaschmidt juliaaschmidt commented Oct 31, 2024

Add Redeem Manager failure test to increase code coverage (PE-1432)

Adds a test for an uncovered redeem manager transfer error scenario

Increases code coverage to 95.57% from currently 95.03%

With this Test:
https://app.codecov.io/github/liquid-collective/liquid-collective-protocol/commit/1bee37d241269e39ea6d5c3c3f720cb8815353d6

Current Coverage on Main:
https://app.codecov.io/gh/liquid-collective/liquid-collective-protocol/commit/76d9173f9989ecba6d9b0b8e492ef81c090e7fae

Notice

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you assigned this PR to yourself?
  • Have you added at least 1 reviewer?
  • Have you updated the official documentation?
  • Have you added sufficient documentation in your code?
  • Have you added relevant tests to the official test suite?

Pull Request Type

  • 💫 New Feature (Breaking Change)
  • 💫 New Feature (Non-breaking Change)
  • 🛠️ Bug fix (Non-breaking Change: Fixes an issue)
  • 🕹️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)

Breaking changes (if applicable)

Testing

  • Have you tested this code with the official test suite?
  • Have you tested this code manually?

Manual tests (if applicable)

Additional comments

@juliaaschmidt juliaaschmidt changed the title Add Redeem Manager test to increase coverage Add Redeem Manager test to increase coverage PE-1432 Oct 31, 2024
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.03%. Comparing base (76d9173) to head (b396029).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #305   +/-   ##
=======================================
  Coverage   95.03%   95.03%           
=======================================
  Files          75       75           
  Lines        1773     1773           
  Branches      235      235           
=======================================
  Hits         1685     1685           
  Misses         29       29           
  Partials       59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mischat mischat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woohoo

@juliaaschmidt juliaaschmidt merged commit a419ced into main Oct 31, 2024
20 checks passed
@juliaaschmidt juliaaschmidt deleted the fix/coverage-too-low-because-untested-migration-stuff branch October 31, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants