Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added certora CI workflow [PE-11] #304

Merged
merged 5 commits into from
Nov 25, 2024
Merged

Conversation

iamsahu
Copy link
Contributor

@iamsahu iamsahu commented Oct 21, 2024

Description

This PR integrates the certora verification into the CI. The prover would run on any new changes being pushed to the repo.

Here is the original PR created by the Certora team. We have just recreated the original PR.

Notice

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you assigned this PR to yourself?
  • Have you added at least 1 reviewer?
  • Have you updated the official documentation?
  • Have you added sufficient documentation in your code?
  • Have you added relevant tests to the official test suite?

Pull Request Type

  • 💫 New Feature (Breaking Change)
  • 💫 New Feature (Non-breaking Change)
  • 🛠️ Bug fix (Non-breaking Change: Fixes an issue)
  • 🕹️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)

Breaking changes (if applicable)

Testing

  • Have you tested this code with the official test suite?
  • Have you tested this code manually?

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.03%. Comparing base (a419ced) to head (c870119).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #304   +/-   ##
=======================================
  Coverage   95.03%   95.03%           
=======================================
  Files          75       75           
  Lines        1773     1773           
  Branches      235      235           
=======================================
  Hits         1685     1685           
  Misses         29       29           
  Partials       59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@iamsahu iamsahu changed the title Added certora CI workflow Added certora CI workflow [PE-11] Nov 5, 2024
@iamsahu iamsahu self-assigned this Nov 5, 2024
@iamsahu iamsahu marked this pull request as ready for review November 5, 2024 11:32
Copy link
Contributor

@juliaaschmidt juliaaschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we're actually changing any of it?

Did they write a proof for the mitigated front-running attack? Didn't see it, but the PR is massive.

certora/specs/RedeemManagerV1.spec Show resolved Hide resolved
certora/specs/RedeemManagerV1.spec Show resolved Hide resolved
certora/specs/RedeemManagerV1.spec Show resolved Hide resolved
certora/specs/RiverV1.spec Show resolved Hide resolved
certora/specs/RiverV1.spec Show resolved Hide resolved
certora/specs/SharesManagerV1.spec Show resolved Hide resolved
certora/specs/SharesManagerV1.spec Show resolved Hide resolved
Copy link
Contributor

@koderholic koderholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mischat mischat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@iamsahu iamsahu merged commit 968a3a3 into main Nov 25, 2024
29 checks passed
@iamsahu iamsahu deleted the chore/certora-ci-integration branch November 25, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants