Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isUnlockGlobal to getVestingSchedule getter (ETH-1656) #262

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

iamsahu
Copy link
Contributor

@iamsahu iamsahu commented Mar 11, 2024

Description

Notice

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you assigned this PR to yourself?
  • Have you added at least 1 reviewer?
  • Have you updated the official documentation?
  • Have you added sufficient documentation in your code?
  • Have you added relevant tests to the official test suite?

Pull Request Type

  • 💫 New Feature (Breaking Change)
  • 💫 New Feature (Non-breaking Change)
  • 🛠️ Bug fix (Non-breaking Change: Fixes an issue)
  • 🕹️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.52%. Comparing base (53d70ab) to head (267712f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #262   +/-   ##
=======================================
  Coverage   95.52%   95.52%           
=======================================
  Files          75       75           
  Lines        1743     1743           
  Branches      235      235           
=======================================
  Hits         1665     1665           
  Misses         24       24           
  Partials       54       54           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iamsahu iamsahu self-assigned this Mar 21, 2024
@iamsahu iamsahu marked this pull request as ready for review May 16, 2024 09:25
@iamsahu iamsahu requested a review from cebidhem as a code owner May 16, 2024 09:25
koderholic
koderholic previously approved these changes Sep 11, 2024
Copy link
Contributor

@koderholic koderholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@juliaaschmidt juliaaschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 🚀

@iamsahu iamsahu requested a review from koderholic September 12, 2024 09:15
@iamsahu iamsahu requested a review from mischat as a code owner October 10, 2024 12:05
@mischat
Copy link
Member

mischat commented Nov 25, 2024

@iamsahu do we still want to get this PR merged in ? It is still relevant ? If so, could you please fix the conflict, and lets try and get it merged in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants