Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to new Hibernate 6.2 Generator API + Hibernate 6.3 breaking changes #508

Merged
merged 15 commits into from
Sep 22, 2023
Merged

Switch to new Hibernate 6.2 Generator API + Hibernate 6.3 breaking changes #508

merged 15 commits into from
Sep 22, 2023

Conversation

filipelautert
Copy link
Collaborator

@filipelautert filipelautert commented Jul 19, 2023 •
edited
Loading

Hibernate 6.2 introduced new APIs and deprecated the ones being used by Liquibase. This PR:

  • switch Liquibase code to use the new API.
  • change other methods to make the extension compatible with Hibernate 6.3
  • start using java 11 improvements

Fix issue #495

@filipelautert filipelautert self-assigned this Jul 19, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 19, 2023 •
edited
Loading

Test Results

27 files   -   9  27 suites   - 9   41s ⏱️ -5s
21 tests ±  0  21 ✔️ +9  0 💤 ±0  0 ❌ ±0 
63 runs   - 21  63 ✔️  - 3  0 💤 ±0  0 ❌ ±0 

Results for commit 801d00b. ± Comparison against base commit 8f45e5f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

Testing These Changes

To test this PR, use the artifacts attached to the latest CI build

Artifacts Available:

  • liquibase-hibernate-artifacts: Zip containing the .jar file to test
  • test-reports-*: Detailed automated test results

Download with liquibase-sdk-maven-plugin

Alternately, you can use the Liquibase SDK Maven Plugin

Download the artifacts

mvn org.liquibase.ext:liquibase-sdk-maven-plugin:0.10.20:download-snapshot-artifacts -Dliquibase.sdk.repo=liquibase/liquibase-hibernate -Dliquibase.sdk.branchSearch=liquibase:fix-hibernate-6.2.x -Dliquibase.sdk.downloadDirectory=download -Dliquibase.sdk.artifactPattern=*-artifacts -Dliquibase.sdk.unzipArtifacts=true

Install to your local maven cache

mvn org.liquibase.ext:liquibase-sdk-maven-plugin:0.10.20:install-snapshot -Dliquibase.sdk.repo=liquibase/liquibase-hibernate -Dliquibase.sdk.branchSearch=liquibase:fix-hibernate-6.2.x

This was referenced Jul 19, 2023
Merged
Closed
@filipelautert filipelautert changed the title Switch to new Hibernate 6.2 Generator API Switch to new Hibernate 6.2 Generator API + Hibernate 6.3 breaking changes Sep 13, 2023
@filipelautert
Hibernate 6.3.0
838ca9d
@filipelautert
Merge remote-tracking branch 'origin/main' into fix-hibernate-6.2.x
8047e55 
# Conflicts:
#	.github/workflows/test.yml
#	pom.xml
#	src/main/java/liquibase/ext/hibernate/snapshot/TableSnapshotGenerator.java
@filipelautert
Supports Hibernate 6.2.x and 6.3.x
5588576
@filipelautert
Copy link
Collaborator Author

@tati-qalified can you help to test this one?

@filipelautert filipelautert merged commit a8a7f90 into main Sep 22, 2023
9 checks passed
@filipelautert filipelautert deleted the fix-hibernate-6.2.x branch September 22, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rberezen rberezen rberezen approved these changes

@MalloD12 MalloD12 MalloD12 approved these changes

@suryaaki2 suryaaki2 suryaaki2 approved these changes

Assignees

@filipelautert filipelautert

Labels
None yet
Projects
Liquibase Open Source
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@filipelautert @rberezen @MalloD12 @suryaaki2 @kevin-atx