Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flags] gateway flags refactoring #2972

Merged
merged 1 commit into from
Mar 7, 2025
Merged

[Flags] gateway flags refactoring #2972

merged 1 commit into from
Mar 7, 2025

Conversation

cheina97
Copy link
Member

@cheina97 cheina97 commented Mar 4, 2025

Description

This PR refactors every flag about gateways adding the gw- suffix.

@adamjensenbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • feat: 🚀 New Feature
  • fix: 🐛 Bug Fix
  • refactor: 🧹 Code Refactoring
  • docs: 📝 Documentation
  • style: 💄 Code Style
  • perf: 🐎 Performance Improvement
  • test: ✅ Tests
  • chore: 🚚 Dependencies Management
  • build: 📦 Builds Management
  • ci: 👷 CI/CD
  • revert: ⏪ Reverts Previous Changes

@github-actions github-actions bot added the chore Miscellaneous tasks that don't modify application logic (e.g., updating dependencies or build tasks) label Mar 4, 2025
@cheina97 cheina97 changed the title [Falgs] gateway flags refactoring [Flags] gateway flags refactoring Mar 4, 2025
@cheina97 cheina97 force-pushed the frc/gwflags branch 3 times, most recently from 695e267 to 410431f Compare March 4, 2025 11:07
@cheina97 cheina97 closed this Mar 4, 2025
@pull-request-size pull-request-size bot added size/XS and removed size/L labels Mar 4, 2025
@github-actions github-actions bot removed the chore Miscellaneous tasks that don't modify application logic (e.g., updating dependencies or build tasks) label Mar 4, 2025
@cheina97 cheina97 reopened this Mar 4, 2025
@cheina97
Copy link
Member Author

cheina97 commented Mar 4, 2025

/test

@cheina97 cheina97 marked this pull request as draft March 4, 2025 13:38
@cheina97 cheina97 closed this Mar 4, 2025
@cheina97 cheina97 reopened this Mar 4, 2025
@cheina97
Copy link
Member Author

cheina97 commented Mar 4, 2025

/test

3 similar comments
@cheina97
Copy link
Member Author

cheina97 commented Mar 5, 2025

/test

@cheina97
Copy link
Member Author

cheina97 commented Mar 5, 2025

/test

@cheina97
Copy link
Member Author

cheina97 commented Mar 5, 2025

/test

@pull-request-size pull-request-size bot added size/L and removed size/XS labels Mar 5, 2025
@github-actions github-actions bot added the chore Miscellaneous tasks that don't modify application logic (e.g., updating dependencies or build tasks) label Mar 5, 2025
@cheina97 cheina97 marked this pull request as ready for review March 5, 2025 14:55
@cheina97 cheina97 force-pushed the frc/gwflags branch 3 times, most recently from 9cab84e to a9a7367 Compare March 7, 2025 13:57
fra98
fra98 approved these changes Mar 7, 2025
View reviewed changes
fra98
fra98 reviewed Mar 7, 2025
View reviewed changes
@cheina97 cheina97 force-pushed the frc/gwflags branch 2 times, most recently from 3da15e4 to 6e96864 Compare March 7, 2025 14:13
@cheina97
Copy link
Member Author

cheina97 commented Mar 7, 2025

/rebase test=true

@fra98
Copy link
Member

fra98 commented Mar 7, 2025

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Mar 7, 2025
@adamjensenbot adamjensenbot merged commit f0a690a into liqotech:master Mar 7, 2025
14 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fra98 fra98 fra98 approved these changes

Assignees
No one assigned
Labels
chore Miscellaneous tasks that don't modify application logic (e.g., updating dependencies or build tasks) size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cheina97 @adamjensenbot @fra98